lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Oct 2019 14:31:49 +0200 From: Andrew Lunn <andrew@...n.ch> To: Vivien Didelot <vivien.didelot@...il.com> Cc: "David S. Miller" <davem@...emloft.net>, linux-kernel@...r.kernel.org, Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org Subject: Re: [PATCH net-next 01/16] net: dsa: use dsa_to_port helper everywhere On Sat, Oct 19, 2019 at 11:19:26PM -0400, Vivien Didelot wrote: > Do not let the drivers access the ds->ports static array directly > while there is a dsa_to_port helper for this purpose. > > At the same time, un-const this helper since the SJA1105 driver > assigns the priv member of the returned dsa_port structure. Hi Vivien Is priv the only member we expect drivers to change? Is the rest private to the core/RO? Rather then remove the const, i wonder if it would be better to add a helper to set priv? Otherwise: Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists