netdev - Re: [patch net-next v3 3/3] devlink: add format requirement for devlink object names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191021155630.GY2185@nanopsycho>
Date:   Mon, 21 Oct 2019 17:56:30 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        jakub.kicinski@...ronome.com, andrew@...n.ch, mlxsw@...lanox.com
Subject: Re: [patch net-next v3 3/3] devlink: add format requirement for
 devlink object names

Mon, Oct 21, 2019 at 05:20:07PM CEST, dsahern@...il.com wrote:
>On 10/21/19 8:26 AM, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> Currently, the name format is not required by the code, however it is
>> required during patch review. All params added until now are in-lined
>> with the following format:
>> 1) lowercase characters, digits and underscored are allowed
>> 2) underscore is neither at the beginning nor at the end and
>>    there is no more than one in a row.
>> 
>> Add checker to the code to require this format from drivers and warn if
>> they don't follow. This applies to params, resources, reporters,
>> traps, trap groups, dpipe tables and dpipe fields.
>> 
>
>This seems random and without any real cause. There is no reason to
>exclude dash and uppercase for example in the names.

I forgot to update the desc. Uppercase chars are now allowed as Andrew
requested. Regarding dash, it could be allowed of course. But why isn't
"_" enough. I mean, I think it would be good to maintain allowed chars
within a limit.
>