netdev - Re: [PATCH 00/10 net-next] page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a82be17dbaa84d4868d6825967b8a87afa3551ba.camel@mellanox.com>
Date:   Mon, 21 Oct 2019 19:08:41 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "jonathan.lemon@...il.com" <jonathan.lemon@...il.com>
CC:     "kernel-team@...com" <kernel-team@...com>,
        "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>,
        Tariq Toukan <tariqt@...lanox.com>,
        "brouer@...hat.com" <brouer@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 00/10 net-next] page_pool cleanups

On Fri, 2019-10-18 at 16:32 -0700, Jonathan Lemon wrote:
> 
> On 18 Oct 2019, at 13:50, Saeed Mahameed wrote:
> 
> > On Wed, 2019-10-16 at 15:50 -0700, Jonathan Lemon wrote:
> > > This patch combines work from various people:
> > > - part of Tariq's work to move the DMA mapping from
> > >   the mlx5 driver into the page pool.  This does not
> > >   include later patches which remove the dma address
> > >   from the driver, as this conflicts with AF_XDP.
> > > 
> > > - Saeed's changes to check the numa node before
> > >   including the page in the pool, and flushing the
> > >   pool on a node change.
> > > 
> > 
> > Hi Jonathan, thanks for submitting this,
> > the patches you have are not up to date, i have new ones with
> > tracing
> > support and some fixes from offlist review iterations, plus
> > performance
> > numbers and a  cover letter.
> > 
> > I will send it to you and you can post it as v2 ?
> 
> Sure, I have some other cleanups to do and have a concern about
> the cache effectiveness for some workloads.

Ok then, I will submit the page pool NUMA change patches separately.
I will remove the flush mechanism and will add your changes.

for the other patches, mlx5 cache and page pool statistics, i think
they need some more work and a lot of pieces are still WIP. I don't
want to block the NUMA change API patches.