netdev - Re: [PATCH] xen/netback: cleanup init and deinit code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <383da9a4-862f-f199-76d6-124711095de4@suse.com>
Date:   Mon, 21 Oct 2019 07:30:17 +0200
From:   Jürgen Groß <jgross@...e.com>
To:     xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Wei Liu <wei.liu@...nel.org>, Paul Durrant <paul@....org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] xen/netback: cleanup init and deinit code

On 21.10.19 07:27, Juergen Gross wrote:
> Do some cleanup of the netback init and deinit code:
> 
> - add an omnipotent queue deinit function usable from
>    xenvif_disconnect_data() and the error path of xenvif_connect_data()
> - only install the irq handlers after initializing all relevant items
>    (especially the kthreads related to the queue)
> - there is no need to use get_task_struct() after creating a kthread
>    and using put_task_struct() again after having stopped it.
> - use kthread_run() instead of kthread_create() to spare the call of
>    wake_up_process().
> 
> Signed-off-by: Juergen Gross <jgross@...e.com>

Sorry, forgot to add the "Reviewed-by:" of Paul. Will resend.


Juergen