netdev - Re: [PATCH 02/33] fix unused parameter warnings in do_version() and show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANP3RGfJJUEm31Qy66et+BWxE40GsaN-XSrtw23rqWgw6CuW1g@mail.gmail.com>
Date:   Mon, 21 Oct 2019 00:17:41 -0700
From:   Maciej Żenczykowski <maze@...gle.com>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     Linux NetDev <netdev@...r.kernel.org>,
        "John W . Linville" <linville@...driver.com>
Subject: Re: [PATCH 02/33] fix unused parameter warnings in do_version() and show_usage()

> Considering how frequent this pattern (a callback where not all
> instances use all parameters) is, maybe we could consider disabling the
> warning with -Wno-unused-parameter instead of marking all places where
> it is issued.

Once you fix it... it stays fixed.  There's no cost to carrying around
the extra annotation.
And the warning still finds other places where you're doing it wrong.