netdev - Re: [patch net-next v2] devlink: add format requirement for devlink param names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191021075830.GR2185@nanopsycho>
Date:   Mon, 21 Oct 2019 09:58:30 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     netdev@...r.kernel.org
Cc:     davem@...emloft.net, jakub.kicinski@...ronome.com, andrew@...n.ch,
        mlxsw@...lanox.com
Subject: Re: [patch net-next v2] devlink: add format requirement for devlink
 param names

Fri, Oct 18, 2019 at 07:09:51PM CEST, jiri@...nulli.us wrote:
>From: Jiri Pirko <jiri@...lanox.com>
>
>Currently, the name format is not required by the code, however it is
>required during patch review. All params added until now are in-lined
>with the following format:
>1) lowercase characters, digits and underscored are allowed
>2) underscore is neither at the beginning nor at the end and
>   there is no more than one in a row.
>
>Add checker to the code to require this format from drivers and warn if
>they don't follow.
>
>Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>---
>v1->v2:
>- removed empty line after comment
>- added check for empty string
>- converted i and len to size_t and put on a single line
>- s/valid_name/name_valid/ to be aligned with the rest

Will send v3 which would allow uppercase and will make it part of
patchset that would check more devlink strings.