netdev - RE: [PATCH net-next 3/4] dpaa2-eth: add MAC/PHY support through phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB2800C58886EC9AF01853EA00E0680@VI1PR0402MB2800.eurprd04.prod.outlook.com>
Date:   Tue, 22 Oct 2019 10:52:59 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>
Subject: RE: [PATCH net-next 3/4] dpaa2-eth: add MAC/PHY support through
 phylink

> Subject: Re: [PATCH net-next 3/4] dpaa2-eth: add MAC/PHY support through
> phylink
> 
> On Tue, Oct 22, 2019 at 01:50:27AM +0300, Ioana Ciornei wrote:
> > +	mac->phylink_config.dev = &net_dev->dev;
> > +	mac->phylink_config.type = PHYLINK_NETDEV;
> > +
> > +	phylink = phylink_create(&mac->phylink_config,
> > +				 of_fwnode_handle(dpmac_node), mac-
> >if_mode,
> > +				 &dpaa2_mac_phylink_ops);
> 
> Does this mean we didn't need to go through the removal of netdev from
> phylink after all?
> 

No, it doesn't mean that.

The change was accepted because it added support for multi-gbps speeds on
DSA CPU ports by using a phylink instance based on the dsa_switch device.
Maxime's initial mail is here - https://www.spinics.net/lists/netdev/msg570450.html.

Ioana