netdev - Re: [PATCH 07/10] net: ehernet: ixp4xx: Use devm_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191021182103.48962e29@cakuba.netronome.com>
Date:   Mon, 21 Oct 2019 18:21:03 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 07/10] net: ehernet: ixp4xx: Use devm_alloc_etherdev()

On Mon, 21 Oct 2019 02:08:21 +0200, Linus Walleij wrote:
> Using the devm_alloc_etherdev() function simplifies the error
> path. I also patch the message to use dev_info().
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  drivers/net/ethernet/xscale/ixp4xx_eth.c | 18 ++++++------------
>  1 file changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
> index fbe328693de5..df18d8ebb170 100644
> --- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
> +++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
> @@ -1378,7 +1378,7 @@ static int ixp4xx_eth_probe(struct platform_device *pdev)
>  
>  	plat = dev_get_platdata(dev);
>  
> -	if (!(ndev = alloc_etherdev(sizeof(struct port))))
> +	if (!(ndev = devm_alloc_etherdev(dev, sizeof(struct port))))
>  		return -ENOMEM;
>  
>  	SET_NETDEV_DEV(ndev, dev);

Okay, I see you do devm_ here.. please reorder the patches, then.