netdev - Re: [PATCH] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6902a1c-af8f-7d47-4f9b-d037c6be70d5@pengutronix.de>
Date:   Tue, 22 Oct 2019 14:58:33 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Vincent Prince <vincent.prince.fr@...il.com>
Cc:     jiri@...nulli.us, jhs@...atatu.com, netdev@...r.kernel.org,
        dave.taht@...il.com, linux-can@...r.kernel.org,
        kernel@...gutronix.de, xiyou.wangcong@...il.com,
        davem@...emloft.net
Subject: Re: [PATCH] net: sch_generic: Use pfifo_fast as fallback scheduler
 for CAN hardware

On 10/22/19 2:47 PM, Vincent Prince wrote:
> Signed-off-by: Vincent Prince <vincent.prince.fr@...il.com>

Please add the patch description, preferred that one from my original patch.

> ---
>  net/sched/sch_generic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> index 77b289d..bff43de 100644
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -1008,6 +1008,8 @@ static void attach_one_default_qdisc(struct net_device *dev,
>  
>  	if (dev->priv_flags & IFF_NO_QUEUE)
>  		ops = &noqueue_qdisc_ops;
> +        else if(dev->type == ARPHRD_CAN)
^^^^^^^^^^^^^^^
use one tab to indent.

> +		ops = &pfifo_fast_ops;
>  
>  	qdisc = qdisc_create_dflt(dev_queue, ops, TC_H_ROOT, NULL);
>  	if (!qdisc) {
> 

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)