netdev - RE: [net-next v3 2/5] e1000e: Add support for S0ix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <804857E1F29AAC47BF68C404FC60A1840109952313@ORSMSX121.amr.corp.intel.com>
Date:   Tue, 22 Oct 2019 16:19:37 +0000
From:   "Allan, Bruce W" <bruce.w.allan@...el.com>
To:     "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "Neftin, Sasha" <sasha.neftin@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "Lifshits, Vitaly" <vitaly.lifshits@...el.com>,
        Rajneesh Bhardwaj <rajneesh.bhardwaj@...ux.intel.com>,
        "Brown, Aaron F" <aaron.f.brown@...el.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
Subject: RE: [net-next v3 2/5] e1000e: Add support for S0ix

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of Jeff Kirsher
> Sent: Monday, October 21, 2019 11:02 AM
> To: davem@...emloft.net
> Cc: Neftin, Sasha <sasha.neftin@...el.com>; netdev@...r.kernel.org;
> nhorman@...hat.com; sassmann@...hat.com; Wysocki, Rafael J
> <rafael.j.wysocki@...el.com>; Lifshits, Vitaly <vitaly.lifshits@...el.com>;
> Rajneesh Bhardwaj <rajneesh.bhardwaj@...ux.intel.com>; Brown, Aaron F
> <aaron.f.brown@...el.com>; Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>
> Subject: [net-next v3 2/5] e1000e: Add support for S0ix
> 
> From: Sasha Neftin <sasha.neftin@...el.com>
> 
> Implement flow for S0ix support. Modern SoCs support S0ix low power
> states during idle periods, which are sub-states of ACPI S0 that increase
> power saving while supporting an instant-on experience for providing
> lower latency that ACPI S0. The S0ix states shut off parts of the SoC
> when they are not in use, while still maintaning optimal performance.
> This patch add support for S0ix started from an Ice Lake platform.
> 
> Suggested-by: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
> Signed-off-by: Vitaly Lifshits <vitaly.lifshits@...el.com>
> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@...ux.intel.com>
> Signed-off-by: Sasha Neftin <sasha.neftin@...el.com>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 182 +++++++++++++++++++++
>  drivers/net/ethernet/intel/e1000e/regs.h   |   4 +
>  2 files changed, 186 insertions(+)

This patch generates warnings that e1000e_s0ix_entry_flow and e1000e_s0ix_exit_flow
are defined but not used [-Wunused-function] when CONFIG_PM_SLEEP is not defined.

The warnings were called out by Intel's 0-DAY kernel test infrastructure after this patch
was merged into the dev-queue branch of Jeff's next-queue tree, so any fix for the warnings
should include the tag " Reported-by: kbuild test robot <lkp@...el.com>".

Bruce.