netdev - [PATCH net-next 0/9] devlink vdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Oct 2019 20:43:01 +0300
From:   Yuval Avnery <yuvalav@...lanox.com>
To:     netdev@...r.kernel.org
Cc:     jiri@...lanox.com, saeedm@...lanox.com, leon@...nel.org,
        davem@...emloft.net, jakub.kicinski@...ronome.com,
        shuah@...nel.org, Yuval Avnery <yuvalav@...lanox.com>
Subject: [PATCH net-next 0/9] devlink vdev

This patchset introduces devlink vdev.

Currently, legacy tools do not provide a comprehensive solution that can
be used in both SmartNic and non-SmartNic mode.
Vdev represents a device that exists on the ASIC but is not necessarily
visible to the kernel.

Using devlink ports is not suitable because:

1. Those devices aren't necessarily network devices (such as NVMe devices)
   and doesn’t have E-switch representation. Therefore, there is need for
   more generic representation of PCI VF.
2. Some attributes are not necessarily pure port attributes
   (number of MSIX vectors)
3. It creates a confusing devlink topology, with multiple port flavours
   and indices.

Vdev will be created along with flavour and attributes.
Some network vdevs may be linked with a devlink port.

This is also aimed to replace "ip link vf" commands as they are strongly
linked to the PCI topology and allow access only to enabled VFs.
Even though current patchset and example is limited to MAC address
of the VF, this interface will allow to manage PF, VF, mdev in
SmartNic and non SmartNic modes, in unified way for networking and
non-networking devices via devlink instance.

Example:

A privileged user wants to configure a VF's hw_addr, before the VF is
enabled.

$ devlink vdev set pci/0000:03:00.0/1 hw_addr 10:22:33:44:55:66

$ devlink vdev show pci/0000:03:00.0/1
pci/0000:03:00.0/1: flavour pcivf pf 0 vf 0 port_index 1 hw_addr 10:22:33:44:55:66

$ devlink vdev show pci/0000:03:00.0/1 -jp
{
    "vdev": {
        "pci/0000:03:00.0/1": {
            "flavour": "pcivf",
            "pf": 0,
            "vf": 0,
            "port_index": 1,
            "hw_addr": "10:22:33:44:55:66"
        }
    }
}

Patches 1-5 adds devlink support for vdev.
Patches 6-7 adds netdevsim implementation and test.
Patch 9 adds mlx5 vdev creation and hw_addr get/set.

Yuval Avnery (9):
  devlink: Introduce vdev
  devlink: Add PCI attributes support for vdev
  devlink: Add port with vdev register support
  devlink: Support vdev HW address get
  devlink: Support vdev HW address set
  netdevsim: Add max_vfs to bus_dev
  netdevsim: Add devlink vdev creation
  netdevsim: Add devlink vdev sefltest for netdevsim
  net/mlx5e: Add support for devlink vdev and vdev hw_addr set/show

 .../net/ethernet/mellanox/mlx5/core/devlink.c |  86 ++++
 .../net/ethernet/mellanox/mlx5/core/devlink.h |   5 +
 .../net/ethernet/mellanox/mlx5/core/en_main.c |   6 +-
 .../net/ethernet/mellanox/mlx5/core/en_rep.c  |   9 +-
 .../net/ethernet/mellanox/mlx5/core/eswitch.c |  19 +-
 .../net/ethernet/mellanox/mlx5/core/eswitch.h |   7 +-
 .../mellanox/mlx5/core/eswitch_offloads.c     |   8 +
 drivers/net/netdevsim/Makefile                |   2 +-
 drivers/net/netdevsim/bus.c                   |  39 +-
 drivers/net/netdevsim/dev.c                   |   9 +-
 drivers/net/netdevsim/netdevsim.h             |  11 +
 drivers/net/netdevsim/vdev.c                  |  96 +++++
 include/net/devlink.h                         |  44 ++
 include/uapi/linux/devlink.h                  |  16 +
 net/core/devlink.c                            | 393 +++++++++++++++++-
 .../drivers/net/netdevsim/devlink.sh          |  55 ++-
 16 files changed, 777 insertions(+), 28 deletions(-)
 create mode 100644 drivers/net/netdevsim/vdev.c

-- 
2.17.1