netdev - Re: [net 04/15] net/mlx5e: kTLS, Size of a Dump WQE is fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Oct 2019 18:06:11 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "jakub.kicinski@...ronome.com" <jakub.kicinski@...ronome.com>
CC:     Eran Ben Elisha <eranbe@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...lanox.com>
Subject: Re: [net 04/15] net/mlx5e: kTLS, Size of a Dump WQE is fixed

On Fri, 2019-10-18 at 16:13 -0700, Jakub Kicinski wrote:
> On Fri, 18 Oct 2019 19:38:09 +0000, Saeed Mahameed wrote:
> > From: Tariq Toukan <tariqt@...lanox.com>
> > 
> > No Eth segment, so no dynamic inline headers.
> > The size of a Dump WQE is fixed, use constants and remove
> > unnecessary checks.
> > 
> > Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support")
> > Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
> > Reviewed-by: Eran Ben Elisha <eranbe@...lanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> 
> Is this a fix?


sort of, this patch fundamentally changes the way mlx5 treats kTLS TX
descriptors, to make downstream patches simpler and more correct.