netdev - Re: [PATCH net-next 0/4] r8169: remove fiddling with the PCIe max read request size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191022113617.3c5c4dfc@cakuba.netronome.com>
Date:   Tue, 22 Oct 2019 11:36:17 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 0/4] r8169: remove fiddling with the PCIe max
 read request size

On Mon, 21 Oct 2019 21:21:23 +0200, Heiner Kallweit wrote:
> The attempt to improve performance by changing the PCIe max read request
> size was added in the vendor driver more than 10 years back and copied
> to r8169 driver. In the vendor driver this has been removed long ago.
> Obviously it had no effect, also in my tests I didn't see any
> difference. Typically the max payload size is less than 512 bytes
> anyway, and the PCI core takes care that the maximum supported value
> is set. So let's remove fiddling with PCIe max read request size from
> r8169 too. This change allows to simplify the driver in the subsequent
> three patches of this series.

Applied, thanks!