netdev - Re: [PATCH net-next v2 5/6] dpaa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191022141436.4f727890@cakuba.netronome.com>
Date:   Tue, 22 Oct 2019 14:14:36 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Madalin Bucur <madalin.bucur@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, roy.pledge@....com,
        laurentiu.tudor@....com
Subject: Re: [PATCH net-next v2 5/6] dpaa_eth: change DMA device

On Tue, 22 Oct 2019 14:15:00 +0300, Madalin Bucur wrote:
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index 8d5686d88d30..639cafaa59b8 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -1335,15 +1335,15 @@ static void dpaa_fd_release(const struct net_device *net_dev,
>  		vaddr = phys_to_virt(qm_fd_addr(fd));
>  		sgt = vaddr + qm_fd_get_offset(fd);
>  
> -		dma_unmap_single(dpaa_bp->dev, qm_fd_addr(fd), dpaa_bp->size,
> -				 DMA_FROM_DEVICE);
> +		dma_unmap_single(dpaa_bp->priv->rx_dma_dev, qm_fd_addr(fd),
> +				 dpaa_bp->size, DMA_FROM_DEVICE);
>  
>  		dpaa_release_sgt_members(sgt);
>  
> -		addr = dma_map_single(dpaa_bp->dev, vaddr, dpaa_bp->size,
> -				      DMA_FROM_DEVICE);
> -		if (dma_mapping_error(dpaa_bp->dev, addr)) {
> -			dev_err(dpaa_bp->dev, "DMA mapping failed");
> +		addr = dma_map_single(dpaa_bp->priv->rx_dma_dev, vaddr,
> +				      dpaa_bp->size, DMA_FROM_DEVICE);
> +		if (dma_mapping_error(dpaa_bp->priv->rx_dma_dev, addr)) {
> +			netdev_err(net_dev, "DMA mapping failed");

You seem to be missing new line chars at the end of the "DMA mapping
failed" messages :( Could you please fix all of them and repost?

>  			return;
>  		}
>  		bm_buffer_set64(&bmb, addr);