netdev - Re: [PATCH iproute2] ipnetns: do not check netns NAME when -all is specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191023092145.0daebf54@hermes.lan>
Date:   Wed, 23 Oct 2019 09:21:45 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Michał Łyszczek <michal.lyszczek@...c.pl>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH iproute2] ipnetns: do not check netns NAME when -all is
 specified

On Tue, 22 Oct 2019 22:09:23 +0200
Michał Łyszczek <michal.lyszczek@...c.pl> wrote:

> When `-all' argument is specified netns runs cmd on all namespaces
> and NAME is not used, but netns nevertheless checks if argv[1] is a
> valid namespace name ignoring the fact that argv[1] contains cmd
> and not NAME. This results in bug where user cannot specify
> absolute path to command.
> 
>     # ip -all netns exec /usr/bin/whoami
>     Invalid netns name "/usr/bin/whoami"
> 
> This forces user to have his command in PATH.
> 
> Solution is simply to not validate argv[1] when `-all' argument is
> specified.
> 
> Signed-off-by: Michał Łyszczek <michal.lyszczek@...c.pl>

Looks good, applied thanks