netdev - Re: [PATCH bpf v3] xsk: improve documentation for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQKMJX1eADxgK8ixmUd7XFKOOjdhbCybFcLCLEaUXUSuAw@mail.gmail.com>
Date:   Wed, 23 Oct 2019 10:16:42 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Magnus Karlsson <magnus.karlsson@...el.com>
Cc:     Björn Töpel <bjorn.topel@...el.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Network Development <netdev@...r.kernel.org>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf v3] xsk: improve documentation for AF_XDP

On Mon, Oct 21, 2019 at 1:57 AM Magnus Karlsson
<magnus.karlsson@...el.com> wrote:
>
> Added sections on all the bind flags, libbpf, all the setsockopts and
> all the getsockopts. Also updated the document to reflect the latest
> features and to correct some spelling errors.
>
> v1 -> v2:
> * Updated XDP program with latest BTF map format
> * Added one more FAQ entry
> * Some minor edits and corrections
>
> v2 -> v3:
> * Simplified XDP_SHARED_UMEM example XDP program
>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@...el.com>
..
> +   struct xdp_statistics {
> +         __u64 rx_dropped; /* Dropped for reasons other than invalid desc */
> +         __u64 rx_invalid_descs; /* Dropped due to invalid descriptor */
> +         __u64 tx_invalid_descs; /* Dropped due to invalid descriptor */
> +   };

there was small space/tab damage in the above.
I fixed it up and applied to bpf-next.
Sounds like there could be tweaks to this doc in this release cycle
when you follow up with btf and libbpf additions.