netdev - Re: [PATCH net-next 2/6] ionic: reverse an interrupt coalesce calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a81e4f85-68db-555d-047d-b6d6f5997b68@pensando.io>
Date:   Tue, 22 Oct 2019 19:09:40 -0700
From:   Shannon Nelson <snelson@...sando.io>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 2/6] ionic: reverse an interrupt coalesce
 calculation

On 10/22/19 6:22 PM, Andrew Lunn wrote:
> On Tue, Oct 22, 2019 at 01:31:09PM -0700, Shannon Nelson wrote:
>> Fix the initial interrupt coalesce usec-to-hw setting
>> to actually be usec-to-hw.
>>
>> Fixes: 780eded34ccc ("ionic: report users coalesce request")
>> Signed-off-by: Shannon Nelson <snelson@...sando.io>
> Hi Shannon
>
> How bad is this? Should it be backported? If so, you should send it as
> a separate patch for net.
>
>    Andrew

Well, it doesn't "break" anything, but it does end up initializing the 
coalesce value to 0, aka turns it off.  The easy work-around is for the 
user to set a new value, then all is well.  However, since v5.4 is 
intended as an LTS, this probably should get promoted into net.  If 
there aren't many other comments, I'll likely turn this around tomorrow 
afternoon.

sln