netdev - Re: [PATCH net-next 0/2] mlxsw: Update main pool computation and pool size limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191023.213158.1339777924202893007.davem@davemloft.net>
Date:   Wed, 23 Oct 2019 21:31:58 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, jakub.kicinski@...ronome.com,
        jiri@...lanox.com, petrm@...lanox.com, mlxsw@...lanox.com,
        idosch@...lanox.com
Subject: Re: [PATCH net-next 0/2] mlxsw: Update main pool computation and
 pool size limits

From: Ido Schimmel <idosch@...sch.org>
Date: Wed, 23 Oct 2019 09:04:58 +0300

> From: Ido Schimmel <idosch@...lanox.com>
> 
> Petr says:
> 
> In Spectrum ASICs, the shared buffer is an area of memory where packets are
> kept until they can be transmitted. There are two resources associated with
> shared buffer size: cap_total_buffer_size and cap_guaranteed_shared_buffer.
> So far, mlxsw has been using the former as a limit when validating shared
> buffer pool size configuration. However, the total size also includes
> headrooms and reserved space, which really cannot be used for shared buffer
> pools. Patch #1 mends this and has mlxsw use the guaranteed size.
> 
> To configure default pool sizes, mlxsw has historically hard-coded one or
> two smallish pools, and one "main" pool that took most of the shared buffer
> (that would be pool 0 on ingress and pool 4 on egress). During the
> development of Spectrum-2, it became clear that the shared buffer size
> keeps shrinking as bugs are identified and worked around. In order to
> prevent having to tweak the size of pools 0 and 4 to catch up with updates
> to values reported by the FW, patch #2 changes the way these pools are set.
> Instead of hard-coding a fixed value, the main pool now takes whatever is
> left from the guaranteed size after the smaller pool(s) are taken into
> account.

Series applied, thanks.