netdev - Re: [EXT] [PATCH net-next] net: aquantia: Fix build error wihtout CONFIG_PTP_1588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Oct 2019 15:06:25 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        Egor Pomozov <epomozov@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>,
        Sergey Samoilenko <Sergey.Samoilenko@...antia.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] [PATCH net-next] net: aquantia: Fix build error wihtout
 CONFIG_PTP_1588_CLOCK


> If PTP_1588_CLOCK is n, building fails:
> 
> drivers/net/ethernet/aquantia/atlantic/aq_ptp.c: In function aq_ptp_adjfine:
> drivers/net/ethernet/aquantia/atlantic/aq_ptp.c:279:11:
>  error: implicit declaration of function scaled_ppm_to_ppb [-Werror=implicit-function-declaration]
>            scaled_ppm_to_ppb(scaled_ppm));

Hi Yue,

Thanks for noticing this. It seems I've added scaled_ppm_to_ppb usage but did
not checked PTP_1588_CLOCK=n case after that.

> 
> Just cp scaled_ppm_to_ppb() from ptp_clock.c to fix this.

I'm honestly not sure if duplicating the code is a good way here.
I'll think on how to exclude at_ptp at all on such a config.

Regards,
  Igor