netdev - Re: [PATCH v3 1/2] dt-bindings: ptp: Add bindings doc for IDT ClockMatrix based PTP clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191025193228.GA31398@bogus>
Date:   Fri, 25 Oct 2019 14:32:28 -0500
From:   Rob Herring <robh@...nel.org>
To:     vincent.cheng.xh@...esas.com
Cc:     devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, andrew@...n.ch, mark.rutland@....com,
        richardcochran@...il.com
Subject: Re: [PATCH v3 1/2] dt-bindings: ptp: Add bindings doc for IDT
 ClockMatrix based PTP clock

On Mon, Oct 21, 2019 at 03:57:47PM -0400, vincent.cheng.xh@...esas.com wrote:
> From: Vincent Cheng <vincent.cheng.xh@...esas.com>
> 
> Add device tree binding doc for the IDT ClockMatrix PTP clock.
> 
> Co-developed-by: Richard Cochran <richardcochran@...il.com>
> Signed-off-by: Richard Cochran <richardcochran@...il.com>
> Signed-off-by: Vincent Cheng <vincent.cheng.xh@...esas.com>
> ---
> 
> Changes since v2:
>  - As suggested by Rob Herring:
>    1. Replace with DT schema
>    2. Remove '-ptp' from compatible string
>    3. Replace wildcard 'x' with the part numbers.
> 
> Changes since v1:
>  - No changes
> ---
>  .../devicetree/bindings/ptp/ptp-idtcm.yaml         | 63 ++++++++++++++++++++++
>  1 file changed, 63 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> 
> diff --git a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> new file mode 100644
> index 0000000..d3771e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ptp/ptp-idtcm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: IDT ClockMatrix (TM) PTP Clock Device Tree Bindings
> +
> +maintainers:
> +  - Vincent Cheng <vincent.cheng.xh@...esas.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      # For System Synchronizer
> +      - idt,8a34000
> +      - idt,8a34001
> +      - idt,8a34002
> +      - idt,8a34003
> +      - idt,8a34004
> +      - idt,8a34005
> +      - idt,8a34006
> +      - idt,8a34007
> +      - idt,8a34008
> +      - idt,8a34009
> +      # For Port Synchronizer
> +      - idt,8a34010
> +      - idt,8a34011
> +      - idt,8a34012
> +      - idt,8a34013
> +      - idt,8a34014
> +      - idt,8a34015
> +      - idt,8a34016
> +      - idt,8a34017
> +      - idt,8a34018
> +      - idt,8a34019
> +      # For Universal Frequency Translator (UFT)
> +      - idt,8a34040
> +      - idt,8a34041
> +      - idt,8a34042
> +      - idt,8a34043
> +      - idt,8a34044
> +      - idt,8a34045
> +      - idt,8a34046
> +      - idt,8a34047
> +      - idt,8a34048
> +      - idt,8a34049
> +
> +  reg:
> +    maxItems: 1
> +    description:
> +      I2C slave address of the device.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    phc@5b {

ptp@5b

Examples are built now and this fails:

Documentation/devicetree/bindings/ptp/ptp-idtcm.example.dts:19.15-28: 
Warning (reg_format): /example-0/phc@5b:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1)

The problem is i2c devices need to be shown under an i2c bus node.

> +          compatible = "idt,8a34000";
> +          reg = <0x5b>;
> +    };
> -- 
> 2.7.4
>