netdev - Re: [PATCH net-next] net: dsa: return directly from dsa_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <abf5753e-34ae-bb0f-d514-41a87d557d9d@gmail.com>
Date:   Fri, 25 Oct 2019 13:02:50 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: return directly from dsa_to_port

On 10/25/19 11:48 AM, Vivien Didelot wrote:
> Return directly from within the loop as soon as the port is found,
> otherwise we won't return NULL if the end of the list is reached.
> 
> Fixes: b96ddf254b09 ("net: dsa: use ports list in dsa_to_port")
> Signed-off-by: Vivien Didelot <vivien.didelot@...il.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

My bad for suggesting a broken way of doing this, so thanks for fixing it ;)
-- 
Florian