netdev - Re: [RFC 01/20] ice: Initialize and register multi-function device to provide RDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Oct 2019 21:30:48 -0400
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     "Ertman, David M" <david.m.ertman@...el.com>
Cc:     Jason Gunthorpe <jgg@...pe.ca>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "dledford@...hat.com" <dledford@...hat.com>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        "Patil, Kiran" <kiran.patil@...el.com>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>
Subject: Re: [RFC 01/20] ice: Initialize and register multi-function device
 to provide RDMA

On Thu, Oct 24, 2019 at 10:25:36PM +0000, Ertman, David M wrote:
> The direct access of the platform bus was unacceptable, and the MFD sub-system
> was suggested by Greg as the solution.  The MFD sub-system uses the platform
> bus in the background as a base to perform its functions, since it is a purely software
> construct that is handy and fulfills its needs.  The question then is:  If the MFD sub-
> system is using the platform bus for all of its background functionality, is the platform
> bus really only for platform devices?

Yes, how many times do I have to keep saying this?

The platform bus should ONLY be used for devices that are actually
platform devices and can not be discovered any other way and are not on
any other type of bus.

If you try to add platform devices for a PCI device, I am going to
continue to complain.  I keep saying this and am getting tired.

Now yes, MFD does do "fun" things here, and that should probably be
fixed up one of these days.  But I still don't see why a real bus would
not work for you.

greg "platform devices are dead, long live the platform device" k-h