netdev - Re: [PATCH v2 bpf-next] bpf: Prepare btf_ctx_access for non raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQKVtRcOex-2Gw7Gg1ut6SBnYCNxE+F2gj9oN604hV1wLw@mail.gmail.com>
Date:   Thu, 24 Oct 2019 18:47:36 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v2 bpf-next] bpf: Prepare btf_ctx_access for non raw_tp
 use case

On Thu, Oct 24, 2019 at 5:18 PM Martin KaFai Lau <kafai@...com> wrote:
>
> This patch makes a few changes to btf_ctx_access() to prepare
> it for non raw_tp use case where the attach_btf_id is not
> necessary a BTF_KIND_TYPEDEF.
>
> It moves the "btf_trace_" prefix check and typedef-follow logic to a new
> function "check_attach_btf_id()" which is called only once during
> bpf_check().  btf_ctx_access() only operates on a BTF_KIND_FUNC_PROTO
> type now. That should also be more efficient since it is done only
> one instead of every-time check_ctx_access() is called.
>
> "check_attach_btf_id()" needs to find the func_proto type from
> the attach_btf_id.  It needs to store the result into the
> newly added prog->aux->attach_func_proto.  func_proto
> btf type has no name, so a proper name should be stored into
> "attach_func_name" also.
>
> v2:
> - Move the "btf_trace_" check to an earlier verifier phase (Alexei)
>
> Signed-off-by: Martin KaFai Lau <kafai@...com>

Thank you for sending it early. It's right in the place that I'm
hacking as well.
I'll refactor my work to base on this.
Applied. Thanks.