netdev - RE: [EXT] [PATCH] net: fec: remove redundant assignment to pointer bdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB3600328E75600B583331C2C2FF640@VI1PR0402MB3600.eurprd04.prod.outlook.com>
Date:   Sat, 26 Oct 2019 04:54:43 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Colin King <colin.king@...onical.com>,
        "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] [PATCH] net: fec: remove redundant assignment to pointer
 bdp

From: Colin King <colin.king@...onical.com> Sent: Saturday, October 26, 2019 1:23 AM
> The pointer bdp is being assigned with a value that is never read, so the
> assignment is redundant and hence can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
Thanks.

Acked-by: Fugang Duan <fugang.duan@....com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index d4d4c72adf49..608196bdd892 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2706,7 +2706,6 @@ static void fec_enet_free_buffers(struct
> net_device *ndev)
> 
>         for (q = 0; q < fep->num_tx_queues; q++) {
>                 txq = fep->tx_queue[q];
> -               bdp = txq->bd.base;
>                 for (i = 0; i < txq->bd.ring_size; i++) {
>                         kfree(txq->tx_bounce[i]);
>                         txq->tx_bounce[i] = NULL;
> --
> 2.20.1