netdev - Re: [PATCH v3 wireless-drivers 0/2] fix mt76x2e hangs on U7612E mini-pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c6bdfd65ae3178cff2f55233e9e8465@natalenko.name>
Date:   Mon, 28 Oct 2019 08:17:02 +0100
From:   Oleksandr Natalenko <oleksandr@...alenko.name>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     kvalo@...eaurora.org, linux-wireless@...r.kernel.org, nbd@....name,
        hkallweit1@...il.com, sgruszka@...hat.com,
        lorenzo.bianconi@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH v3 wireless-drivers 0/2] fix mt76x2e hangs on U7612E
 mini-pcie

On 27.10.2019 20:53, Lorenzo Bianconi wrote:
> Various mt76x2e issues have been reported on U7612E mini-pcie card [1].
> On U7612E-H1 PCIE_ASPM causes continuous mcu hangs and instability and
> so patch 1/2 disable it by default.
> Moreover mt76 does not properly unmap dma buffers for non-linear skbs.
> This issue may result in hw hangs if the system relies on IOMMU.
> Patch 2/2 fix the problem properly unmapping data fragments on
> non-linear skbs.
> 
> Changes since v2:
> - fix compilation error if PCI support is not compiled
> 
> Changes since v1:
> - simplify buf0 unmap condition
> - use IS_ENABLED(CONFIG_PCIEASPM) instead of ifdef CONFIG_PCIEASPM
> - check pci_disable_link_state return value
> 
> [1]:
> https://lore.kernel.org/netdev/deaafa7a3e9ea2111ebb5106430849c6@natalenko.name/
> 
> 
> Lorenzo Bianconi (2):
>   mt76: mt76x2e: disable pcie_aspm by default
>   mt76: dma: fix buffer unmap with non-linear skbs
> 
>  drivers/net/wireless/mediatek/mt76/Makefile   |  2 +
>  drivers/net/wireless/mediatek/mt76/dma.c      |  6 ++-
>  drivers/net/wireless/mediatek/mt76/mt76.h     |  6 ++-
>  .../net/wireless/mediatek/mt76/mt76x2/pci.c   |  2 +
>  drivers/net/wireless/mediatek/mt76/pci.c      | 46 +++++++++++++++++++
>  5 files changed, 58 insertions(+), 4 deletions(-)
>  create mode 100644 drivers/net/wireless/mediatek/mt76/pci.c

So, works fine for me. Checked with 5.3 and additional include fix I've 
mentioned previously.

With that, for the whole series feel free to add:

Reported-by: Oleksandr Natalenko <oleksandr@...alenko.name>
Tested-by: Oleksandr Natalenko <oleksandr@...alenko.name>

Thank you.

-- 
   Oleksandr Natalenko (post-factum)