netdev - Re: [PATCH net-next v2 0/6] sfc: Add XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8af30fef-6998-ed20-ba7c-982c9a4d263a@gmail.com>
Date:   Mon, 28 Oct 2019 16:03:13 -0600
From:   David Ahern <dsahern@...il.com>
To:     Charles McLachlan <cmclachlan@...arflare.com>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
        brouer@...hat.com
Subject: Re: [PATCH net-next v2 0/6] sfc: Add XDP support

On 10/28/19 7:56 AM, Charles McLachlan wrote:
> Supply the XDP callbacks in netdevice ops that enable lower level processing
> of XDP frames.
> 
> Changes since last submission:
> - Use of xdp_return_frame_rx_napi() in tx.c
> - Addition of xdp_rxq_info_valid and xdp_rxq_info_failed to track when
>   xdp_rxq_info failures occur.
> - Renaming of rc to err and more use of unlikely().
> - Cut some duplicated code and fix an array overrun.
> - Actually increment n_rx_xdp_tx when packets are transmitted.
> 
>

Hi:

I was hoping to try out this patch set, but when I rebooted the server
with these applied I hit the BUG_ON in efx_ef10_link_piobufs:

	if (tx_queue->queue == nic_data->pio_write_vi_base) {
		BUG_ON(index != 0);
		...