netdev - Re: [PATCH] net: usb: lan78xx: Disable interrupts before calling generic_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191028.163542.651907517920532587.davem@davemloft.net>
Date:   Mon, 28 Oct 2019 16:35:42 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dwagner@...e.de
Cc:     netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, woojung.huh@...rochip.com,
        maz@...nel.org, andrew@...n.ch, wahrenst@....net,
        Jisheng.Zhang@...aptics.com, bigeasy@...utronix.de,
        tglx@...utronix.de
Subject: Re: [PATCH] net: usb: lan78xx: Disable interrupts before calling
 generic_handle_irq()

From: Daniel Wagner <dwagner@...e.de>
Date: Fri, 25 Oct 2019 10:04:13 +0200

> lan78xx_status() will run with interrupts enabled due to the change in
> ed194d136769 ("usb: core: remove local_irq_save() around ->complete()
> handler"). generic_handle_irq() expects to be run with IRQs disabled.
 ...
> Fixes: ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler")
 ...
> Signed-off-by: Daniel Wagner <dwagner@...e.de>

Applied and queued up for -stable, thanks Daniel.