netdev - Re: [PATCH] net: hisilicon: Fix ping latency when deal with high throughput

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <260be568-cbda-5e27-ac06-d6ee6194a0c2@huawei.com>
Date:   Mon, 28 Oct 2019 09:24:56 +0800
From:   Jiangfeng Xiao <xiaojiangfeng@...wei.com>
To:     Joe Perches <joe@...ches.com>, <davem@...emloft.net>,
        <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <leeyou.li@...wei.com>, <zhanghan23@...wei.com>,
        <nixiaoming@...wei.com>, <zhangqiang.cn@...ilicon.com>,
        <dingjingcheng@...ilicon.com>
Subject: Re: [PATCH] net: hisilicon: Fix ping latency when deal with high
 throughput



On 2019/10/26 23:44, Joe Perches wrote:
> On Sat, 2019-10-26 at 16:49 +0800, Jiangfeng Xiao wrote:
>> This is due to error in over budget processing.
>> When dealing with high throughput, the used buffers
>> that exceeds the budget is not cleaned up. In addition,
>> it takes a lot of cycles to clean up the used buffer,
>> and then the buffer where the valid data is located can take effect.
> []
>> diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c
> []
>> @@ -575,7 +575,7 @@ static int hip04_rx_poll(struct napi_struct *napi, int budget)
>>  	struct hip04_priv *priv = container_of(napi, struct hip04_priv, napi);
>>  	struct net_device *ndev = priv->ndev;
>>  	struct net_device_stats *stats = &ndev->stats;
>> -	unsigned int cnt = hip04_recv_cnt(priv);
>> +	static unsigned int cnt_remaining;
> 
> static doesn't seem a great idea here as it's for just a single
> driver instance.  Maybe make this part of struct hip04_priv?
> 
Thank you for your review. Your suggestion is very good.