netdev - Re: [EXT] [PATCH net-next] net: aquantia: fix error handling in aq_ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c961978-3fb2-730c-fe54-3b7cc2ec9b53@marvell.com>
Date:   Mon, 28 Oct 2019 09:53:32 +0000
From:   Igor Russkikh <irusskikh@...vell.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Egor Pomozov <epomozov@...vell.com>,
        Igor Russkikh <Igor.Russkikh@...antia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Sergey Samoilenko <Sergey.Samoilenko@...antia.com>,
        Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [EXT] [PATCH net-next] net: aquantia: fix error handling in
 aq_ptp_poll


> Fix currenty ignored returned error by properly checking *err* after
> calling aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill().
> 
> Addresses-Coverity-ID: 1487357 ("Unused value")
> Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Thanks, Gustavo!

Reviewed-by: Igor Russkikh <irusskikh@...vell.com>

Regards,
  Igor