netdev - Re: [PATCH] cfg80211: Fix memory leak in cfg80211_inform_single_bss_frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Oct 2019 09:46:51 -0500
From:   Navid Emamdoost <navid.emamdoost@...il.com>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     Navid Emamdoost <emamd001@....edu>,
        Stephen McCamant <smccaman@....edu>, Kangjie Lu <kjlu@....edu>,
        "David S. Miller" <davem@...emloft.net>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cfg80211: Fix memory leak in cfg80211_inform_single_bss_frame_data

On Mon, Oct 28, 2019 at 7:12 AM Johannes Berg <johannes@...solutions.net> wrote:
>
> On Sun, 2019-10-27 at 13:15 -0500, Navid Emamdoost wrote:
> > In the implementation of cfg80211_inform_single_bss_frame_data() the
> > allocated memory for ies is leaked in case of an error. Release ies if
> > cfg80211_bss_update() fails.
>
> I'm pretty sure it's more complicated than this patch (and the previous
> one) - we already do free this at least in the case that "new =
> kzalloc(...)" fails in cfg80211_bss_update().

Now I agree, there are two cases of release for ies in cfg80211_bss_update().
But for future reference, I suspect the last two cases of goto drop to
be mishandling ies.


>
> Your Fixes: tag is also wrong, back then we didn't even have the dynamic
> allocation of the IEs.
>
> I'm dropping this patch and the other and will make a note to eventually
> look at the lifetime issue here you point out, but if you want to work
> on it instead let me know.
>
> johannes
>


-- 
Navid.