netdev - Re: [PATCH bpf-next v3 4/4] selftests: Add tests for automatic map pinning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <483546c6-14b9-e1f1-b4c1-424d6b8d4ace@fb.com>
Date:   Mon, 28 Oct 2019 15:32:26 +0000
From:   Yonghong Song <yhs@...com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>,
        "Jesper Dangaard Brouer" <brouer@...hat.com>
CC:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>, Martin Lau <kafai@...com>,
        Song Liu <songliubraving@...com>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        "David Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v3 4/4] selftests: Add tests for automatic map
 pinning



On 10/28/19 6:15 AM, Toke Høiland-Jørgensen wrote:
> Jesper Dangaard Brouer <brouer@...hat.com> writes:
> 
>> On Sun, 27 Oct 2019 21:53:19 +0100
>> Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>>
>>> diff --git a/tools/testing/selftests/bpf/progs/test_pinning.c b/tools/testing/selftests/bpf/progs/test_pinning.c
>>> new file mode 100644
>>> index 000000000000..ff2d7447777e
>>> --- /dev/null
>>> +++ b/tools/testing/selftests/bpf/progs/test_pinning.c
>>> @@ -0,0 +1,29 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +
>>> +#include <linux/bpf.h>
>>> +#include "bpf_helpers.h"
>>> +
>>> +int _version SEC("version") = 1;
>>> +
>>> +struct {
>>> +	__uint(type, BPF_MAP_TYPE_ARRAY);
>>> +	__uint(max_entries, 1);
>>> +	__type(key, __u32);
>>> +	__type(value, __u64);
>>> +	__uint(pinning, LIBBPF_PIN_BY_NAME);
>>> +} pinmap SEC(".maps");
>>
>> So, this is the new BTF-defined maps syntax.
>>
>> Please remind me, what version of LLVM do we need to compile this?
> 
> No idea what the minimum version is. I'm running LLVM 9.0 :)

LLVM 9.0 starts to support .maps.
There is no dependency on pahole.

> 
>> Or was there a dependency on pahole?
> 
> Don't think so...
> 
> -Toke
>