netdev - Re: [PATCH bpf-next v2 1/2] xsk: store struct xdp_sock as a flexible array member of the XSKMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQLFY3rNSbc5vqPuWmyuczvT6y-tD=zgTcJZX1yeqbVq8w@mail.gmail.com>
Date:   Tue, 29 Oct 2019 06:44:10 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Björn Töpel <bjorn.topel@...il.com>
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Netdev <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Björn Töpel <bjorn.topel@...el.com>,
        bpf <bpf@...r.kernel.org>,
        Magnus Karlsson <magnus.karlsson@...il.com>,
        "Karlsson, Magnus" <magnus.karlsson@...el.com>,
        "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>
Subject: Re: [PATCH bpf-next v2 1/2] xsk: store struct xdp_sock as a flexible
 array member of the XSKMAP

On Mon, Oct 28, 2019 at 11:21 PM Björn Töpel <bjorn.topel@...il.com> wrote:
> Changing bpf_map_charge_init()/bpf_map_area_alloc() size to u64 would
> be the smallest change, together with a 64-to-32 overflow check in
> those functions.

+1. bpf_map_charge_init() already has such check.
Changing them to u64 is probably good idea.