netdev - Re: [PATCHv3 1/1] net: forcedeth: add xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191029103244.3139a6aa@cakuba.hsd1.ca.comcast.net>
Date:   Tue, 29 Oct 2019 10:32:44 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Zhu Yanjun <yanjun.zhu@...cle.com>
Cc:     rain.1986.08.12@...il.com, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [PATCHv3 1/1] net: forcedeth: add xmit_more support

On Mon, 28 Oct 2019 23:30:12 -0400, Zhu Yanjun wrote:
> This change adds support for xmit_more based on the igb commit 6f19e12f6230
> ("igb: flush when in xmit_more mode and under descriptor pressure") and
> commit 6b16f9ee89b8 ("net: move skb->xmit_more hint to softnet data") that
> were made to igb to support this feature. The function netif_xmit_stopped
> is called to check whether transmit queue on device is currently unable to
> send to determine whether we must write the tail because we can add no further
> buffers.
> When normal packets and/or xmit_more packets fill up tx_desc, it is
> necessary to trigger NIC tx reg.
> 

> CC: Joe Jin <joe.jin@...cle.com>
> CC: JUNXIAO_BI <junxiao.bi@...cle.com>
> Reported-and-tested-by: Nan san <nan.1986san@...il.com>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>
> Acked-by: Rain River <rain.1986.08.12@...il.com>

I explained to you nicely that you have to kick on the DMA error cases.

Please stop wasting everyone's time by reposting this.