netdev - Re: [PATCH bpf-next] libbpf: fix off-by-one error in ELF sanity check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd09a18e-812a-4996-bfe0-6d8bb79de788@fb.com>
Date:   Tue, 29 Oct 2019 03:29:00 +0000
From:   Alexei Starovoitov <ast@...com>
To:     Andrii Nakryiko <andriin@...com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>
CC:     "andrii.nakryiko@...il.com" <andrii.nakryiko@...il.com>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH bpf-next] libbpf: fix off-by-one error in ELF sanity check

On 10/28/19 4:37 PM, Andrii Nakryiko wrote:
> libbpf's bpf_object__elf_collect() does simple sanity check after iterating
> over all ELF sections, if checks that .strtab index is correct. Unfortunately,
> due to section indices being 1-based, the check breaks for cases when .strtab
> ends up being the very last section in ELF.
> 
> Fixes: 77ba9a5b48a7 ("tools lib bpf: Fetch map names from correct strtab")
> Signed-off-by: Andrii Nakryiko <andriin@...com>

4 year old bug. Nice!
Applied. Thanks.