netdev - Re: [PATCH v3 net-next] Change in Openvswitch to support MPLS label depth of 3 in ingress direction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Oct 2019 13:29:10 -0700
From:   Pravin Shelar <pshelar@....org>
To:     Martin Varghese <martinvarghesenokia@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>, scott.drennan@...ia.com,
        Jiri Benc <jbenc@...hat.com>,
        "Varghese, Martin (Nokia - IN/Bangalore)" <martin.varghese@...ia.com>
Subject: Re: [PATCH v3 net-next] Change in Openvswitch to support MPLS label
 depth of 3 in ingress direction

On Tue, Oct 29, 2019 at 3:50 AM Martin Varghese
<martinvarghesenokia@...il.com> wrote:
>
> On Tue, Oct 29, 2019 at 12:37:45AM -0700, Pravin Shelar wrote:
> > On Sun, Oct 27, 2019 at 10:54 PM Martin Varghese
> > <martinvarghesenokia@...il.com> wrote:
> > >
> > > From: Martin Varghese <martin.varghese@...ia.com>
> > >
> > > The openvswitch was supporting a MPLS label depth of 1 in the ingress
> > > direction though the userspace OVS supports a max depth of 3 labels.
> > > This change enables openvswitch module to support a max depth of
> > > 3 labels in the ingress.
> > >
> > > Signed-off-by: Martin Varghese <martin.varghese@...ia.com>
> > > ---
> > > Changes in v2:
> > >     - Moved MPLS count validation from datapath to configuration.
> > >     - Fixed set mpls function.
> > >
> > > Changes in v3:
> > >     - Updated the comments section of POP_MPLS action configuration.
> > >     - Moved mpls_label_count variable initialization to ovs_nla_copy_actions.
> > >       The current value of the mpls_label_count variable in the function
> > >       __ovs_nla_copy_actions  will be passed to the functions processing
> > >       nested actions (Eg- validate_and_copy_clone) for validations of the
> > >       nested actions on the cloned packet.
> > >
> > >  net/openvswitch/actions.c      |  2 +-
> > >  net/openvswitch/flow.c         | 20 +++++++---
> > >  net/openvswitch/flow.h         |  9 +++--
> > >  net/openvswitch/flow_netlink.c | 87 +++++++++++++++++++++++++++++++-----------
> > >  4 files changed, 85 insertions(+), 33 deletions(-)
> > >
> > ...
> > > diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c
> > > index d7559c6..65c2e34 100644
> > > --- a/net/openvswitch/flow_netlink.c
> > > +++ b/net/openvswitch/flow_netlink.c
> > > @@ -424,7 +424,7 @@ size_t ovs_key_attr_size(void)
> > >         [OVS_KEY_ATTR_DP_HASH]   = { .len = sizeof(u32) },
> > >         [OVS_KEY_ATTR_TUNNEL]    = { .len = OVS_ATTR_NESTED,
> > >                                      .next = ovs_tunnel_key_lens, },
> > > -       [OVS_KEY_ATTR_MPLS]      = { .len = sizeof(struct ovs_key_mpls) },
> > > +       [OVS_KEY_ATTR_MPLS]      = { .len = OVS_ATTR_VARIABLE },
> > >         [OVS_KEY_ATTR_CT_STATE]  = { .len = sizeof(u32) },
> > >         [OVS_KEY_ATTR_CT_ZONE]   = { .len = sizeof(u16) },
> > >         [OVS_KEY_ATTR_CT_MARK]   = { .len = sizeof(u32) },
> > ovs_key_attr_size() also needs update for MPLS labels.
> >
> Do we need to ?
> In the existing ovs_key_attr_size function i dont see MPLS header size taken into
> account.I assume it is not needed as MPLS being a L3 protocol,either MPLS or IP/IPv6
> can be present.In the key size calculation we are including the 40 bytes of ipv6
> which can accomodate 12 bytes of MPLS header.
>
Yes, IPv6 attribute should cover MPLS.