netdev - Re: [PATCH net] erspan: fix the tun_info options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Oct 2019 17:37:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, u9012063@...il.com
Subject: Re: [PATCH net] erspan: fix the tun_info options_len check for
 erspan

From: Xin Long <lucien.xin@...il.com>
Date: Mon, 28 Oct 2019 23:19:35 +0800

> The check for !md doens't really work for ip_tunnel_info_opts(info) which
> only does info + 1. Also to avoid out-of-bounds access on info, it should
> ensure options_len is not less than erspan_metadata in both erspan_xmit()
> and ip6erspan_tunnel_xmit().
> 
> Fixes: 1a66a836da ("gre: add collect_md mode to ERSPAN tunnel")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thank you.