netdev - Re: [PATCH net-next] vxlan: drop "vxlan" parameter in vxlan_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191030122659.GA23163@netronome.com>
Date:   Wed, 30 Oct 2019 13:27:01 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Guillaume Nault <gnault@...hat.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <jakub.kicinski@...ronome.com>,
        netdev@...r.kernel.org, Roopa Prabhu <roopa@...ulusnetworks.com>
Subject: Re: [PATCH net-next] vxlan: drop "vxlan" parameter in
 vxlan_fdb_alloc()

On Tue, Oct 29, 2019 at 09:57:10PM +0100, Guillaume Nault wrote:
> This parameter has never been used.
> 
> Signed-off-by: Guillaume Nault <gnault@...hat.com>

Reviewed-by: Simon Horman <simon.horman@...ronome.com>

> ---
>  drivers/net/vxlan.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 3d9bcc957f7d..5ffea8e34771 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -793,8 +793,7 @@ static int vxlan_gro_complete(struct sock *sk, struct sk_buff *skb, int nhoff)
>  	return eth_gro_complete(skb, nhoff + sizeof(struct vxlanhdr));
>  }
>  
> -static struct vxlan_fdb *vxlan_fdb_alloc(struct vxlan_dev *vxlan,
> -					 const u8 *mac, __u16 state,
> +static struct vxlan_fdb *vxlan_fdb_alloc(const u8 *mac, __u16 state,
>  					 __be32 src_vni, __u16 ndm_flags)
>  {
>  	struct vxlan_fdb *f;
> @@ -835,7 +834,7 @@ static int vxlan_fdb_create(struct vxlan_dev *vxlan,
>  		return -ENOSPC;
>  
>  	netdev_dbg(vxlan->dev, "add %pM -> %pIS\n", mac, ip);
> -	f = vxlan_fdb_alloc(vxlan, mac, state, src_vni, ndm_flags);
> +	f = vxlan_fdb_alloc(mac, state, src_vni, ndm_flags);
>  	if (!f)
>  		return -ENOMEM;
>  
> -- 
> 2.21.0
>