netdev - Re: [PATCH net 1/1] net/smc: fix refcounting for non-blocking connect()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191029.181038.1190737298290626895.davem@davemloft.net>
Date:   Tue, 29 Oct 2019 18:10:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ubraun@...ux.ibm.com
Cc:     netdev@...r.kernel.org, linux-s390@...r.kernel.org,
        gor@...ux.ibm.com, heiko.carstens@...ibm.com, raspl@...ux.ibm.com,
        kgraul@...ux.ibm.com
Subject: Re: [PATCH net 1/1] net/smc: fix refcounting for non-blocking
 connect()

From: Ursula Braun <ubraun@...ux.ibm.com>
Date: Tue, 29 Oct 2019 12:41:26 +0100

> If a nonblocking socket is immediately closed after connect(),
> the connect worker may not have started. This results in a refcount
> problem, since sock_hold() is called from the connect worker.
> This patch moves the sock_hold in front of the connect worker
> scheduling.
> 
> Reported-by: syzbot+4c063e6dea39e4b79f29@...kaller.appspotmail.com
> Fixes: 50717a37db03 ("net/smc: nonblocking connect rework")
> Reviewed-by: Karsten Graul <kgraul@...ux.ibm.com>
> Signed-off-by: Ursula Braun <ubraun@...ux.ibm.com>

Applied and queued up for -stable, thank you.