netdev - Re: Crash when receiving FIN-ACK in TCP_FIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Oct 2019 13:13:49 -0400
From:   Neal Cardwell <ncardwell@...gle.com>
To:     Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>
Cc:     Netdev <netdev@...r.kernel.org>, Yuchung Cheng <ycheng@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: Crash when receiving FIN-ACK in TCP_FIN_WAIT1 state

On Mon, Oct 28, 2019 at 9:36 PM Subash Abhinov Kasiviswanathan
<subashab@...eaurora.org> wrote:
>
> >> I've queued up a build which logs calls to tcp_write_queue_purge and
> >> clears tp->highest_sack and tp->sacked_out. I will let you know how
> >> it fares by end of week.
> >
> > OK, thanks. That should be a useful data point.
>
> I haven't seen the crash in the testing so far.
> Looks like clearing these values seems to help.

Thanks. Do you mind sharing what your patch looked like, so we can
understand precisely what was changed?

Also, are you able to share what the workload looked like that tickled
this issue? (web client? file server?...)

thanks,
neal