netdev - Re: [PATCH net] vxlan: fix unexpected failure of vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191030.115530.829611129255271384.davem@davemloft.net>
Date:   Wed, 30 Oct 2019 11:55:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ap420073@...il.com
Cc:     roopa@...ulusnetworks.com, netdev@...r.kernel.org
Subject: Re: [PATCH net] vxlan: fix unexpected failure of vxlan_changelink()

From: Taehee Yoo <ap420073@...il.com>
Date: Wed, 30 Oct 2019 08:15:12 +0000

> After commit 0ce1822c2a08 ("vxlan: add adjacent link to limit depth
> level"), vxlan_changelink() could fail because of
> netdev_adjacent_change_prepare().
> netdev_adjacent_change_prepare() returns -EEXIST when old lower device
> and new lower device are same.
> (old lower device is "dst->remote_dev" and new lower device is "lowerdev")
> So, before calling it, lowerdev should be NULL if these devices are same.
> 
> Test command1:
>     ip link add dummy0 type dummy
>     ip link add vxlan0 type vxlan dev dummy0 dstport 4789 vni 1
>     ip link set vxlan0 type vxlan ttl 5
>     RTNETLINK answers: File exists
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Fixes: 0ce1822c2a08 ("vxlan: add adjacent link to limit depth level")
> Signed-off-by: Taehee Yoo <ap420073@...il.com>

Applied, thank you.