netdev - Re: [PATCH net] mlxsw: core: Unpublish devlink parameters during reload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Oct 2019 12:04:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, mlxsw@...lanox.com,
        idosch@...lanox.com
Subject: Re: [PATCH net] mlxsw: core: Unpublish devlink parameters during
 reload

From: Ido Schimmel <idosch@...sch.org>
Date: Wed, 30 Oct 2019 11:04:22 +0200

> From: Jiri Pirko <jiri@...lanox.com>
> 
> The devlink parameter "acl_region_rehash_interval" is a runtime
> parameter whose value is stored in a dynamically allocated memory. While
> reloading the driver, this memory is freed and then allocated again. A
> use-after-free might happen if during this time frame someone tries to
> retrieve its value.
> 
> Since commit 070c63f20f6c ("net: devlink: allow to change namespaces
> during reload") the use-after-free can be reliably triggered when
> reloading the driver into a namespace, as after freeing the memory (via
> reload_down() callback) all the parameters are notified.
> 
> Fix this by unpublishing and then re-publishing the parameters during
> reload.
> 
> Fixes: 98bbf70c1c41 ("mlxsw: spectrum: add "acl_region_rehash_interval" devlink param")
> Fixes: 7c62cfb8c574 ("devlink: publish params only after driver init is done")
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Applied and queued up for -stable.