netdev - Re: [PATCH net] net: annotate accesses to sk->sk_incoming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191030.132738.526564730010192127.davem@davemloft.net>
Date:   Wed, 30 Oct 2019 13:27:38 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net] net: annotate accesses to sk->sk_incoming_cpu

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 30 Oct 2019 13:00:04 -0700

> This socket field can be read and written by concurrent cpus.
> 
> Use READ_ONCE() and WRITE_ONCE() annotations to document this,
> and avoid some compiler 'optimizations'.
> 
> KCSAN reported :
 ...
> Reported by Kernel Concurrency Sanitizer on:
> CPU: 1 PID: 16 Comm: ksoftirqd/1 Not tainted 5.4.0-rc3+ #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable, thanks Eric.