netdev - Re: [PATCH net] net: annotate lockless accesses to sk->sk_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Oct 2019 17:35:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com
Subject: Re: [PATCH net] net: annotate lockless accesses to sk->sk_napi_id

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue, 29 Oct 2019 10:54:44 -0700

> We already annotated most accesses to sk->sk_napi_id
> 
> We missed sk_mark_napi_id() and sk_mark_napi_id_once()
> which might be called without socket lock held in UDP stack.
> 
> KCSAN reported :
> BUG: KCSAN: data-race in udpv6_queue_rcv_one_skb / udpv6_queue_rcv_one_skb
 ...
> Fixes: e68b6e50fa35 ("udp: enable busy polling for all sockets")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable, thanks Eric.