netdev - Re: [PATCH] mlx4_core: fix wrong comment about the reason of subtract one from the max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c0f87dd-bb63-cf0e-66c1-ed01b2a42382@mellanox.com>
Date:   Thu, 31 Oct 2019 14:52:09 +0000
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Yuval Shaia <yuval.shaia@...cle.com>,
        Tariq Toukan <tariqt@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "dotanb@....mellanox.co.il" <dotanb@....mellanox.co.il>,
        Eli Cohen <eli@...lanox.com>,
        Vladimir Sokolovsky <vlad@...lanox.com>
Subject: Re: [PATCH] mlx4_core: fix wrong comment about the reason of subtract
 one from the max_cqes



On 10/31/2019 9:49 AM, Yuval Shaia wrote:
> From: Dotan Barak <dotanb@....mellanox.co.il>
> 
> Signed-off-by: Dotan Barak <dotanb@....mellanox.co.il>
> Signed-off-by: Eli Cohen <eli@...lanox.co.il>
> Signed-off-by: Vladimir Sokolovsky <vlad@...lanox.com>
> Signed-off-by: Yuval Shaia <yuval.shaia@...cle.com>
> ---
>   drivers/net/ethernet/mellanox/mlx4/main.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index fce9b3a24347..dcf6b4628c58 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -514,8 +514,7 @@ static int mlx4_dev_cap(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap)
>   	dev->caps.max_rq_desc_sz     = dev_cap->max_rq_desc_sz;
>   	/*
>   	 * Subtract 1 from the limit because we need to allocate a
> -	 * spare CQE so the HCA HW can tell the difference between an
> -	 * empty CQ and a full CQ.
> +	 * spare CQE to enable resizing the CQ
>   	 */

Please use a dot at EOL.

This is not clear enough, especially without a commit message.

>   	dev->caps.max_cqes	     = dev_cap->max_cq_sz - 1;
>   	dev->caps.reserved_cqs	     = dev_cap->reserved_cqs;
>