netdev - Re: [PATCH bpf-next v4 2/5] libbpf: Store map pin path and status in struct bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzazkT7zUbXydSQJD7bk_0hAkb9SAAsM3bCeZb9Xzs=Zag@mail.gmail.com>
Date:   Thu, 31 Oct 2019 10:43:36 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        David Miller <davem@...emloft.net>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v4 2/5] libbpf: Store map pin path and status in
 struct bpf_map

On Thu, Oct 31, 2019 at 10:31 AM Toke Høiland-Jørgensen <toke@...hat.com> wrote:
>
> Andrii Nakryiko <andrii.nakryiko@...il.com> writes:
>
> > [...]
> >
> >>
> >>         return err;
> >> @@ -4131,17 +4205,24 @@ int bpf_object__unpin_maps(struct bpf_object *obj, const char *path)
> >>                 return -ENOENT;
> >>
> >>         bpf_object__for_each_map(map, obj) {
> >> +               char *pin_path = NULL;
> >>                 char buf[PATH_MAX];
> >
> > you can call buf as pin_path and get rid of extra pointer?
>
> The idea here is to end up with bpf_map__unpin(map, NULL) if path is
> unset. GCC complains if I reassign a static array pointer, so don't
> think I can actually get rid of this?

oh, right, it's nullable pointer, then you do need buf and pin_path,
never mind. I keep forgetting this NULL semantics for pin/unpin :)

>
> -Toke