netdev - Re: [PATCH net 3/4] net: bcmgenet: soft reset 40nm EPHYs before MAC init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f1c2d73-66b8-62c3-d1bd-8b4aec2cf1d7@gmail.com>
Date:   Thu, 31 Oct 2019 11:57:16 -0700
From:   Doug Berger <opendmb@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        bcm-kernel-feedback-list@...adcom.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 3/4] net: bcmgenet: soft reset 40nm EPHYs before MAC
 init

On 10/16/19 8:53 PM, Florian Fainelli wrote:
> 
> 
> On 10/16/2019 4:06 PM, Doug Berger wrote:
>> It turns out that the "Workaround for putting the PHY in IDDQ mode"
>> used by the internal EPHYs on 40nm Set-Top Box chips when powering
>> down puts the interface to the GENET MAC in a state that can cause
>> subsequent MAC resets to be incomplete.
>>
>> Rather than restore the forced soft reset when powering up internal
>> PHYs, this commit moves the invocation of phy_init_hw earlier in
>> the MAC initialization sequence to just before the MAC reset in the
>> open and resume functions. This allows the interface to be stable
>> and allows the MAC resets to be successful.
>>
>> The bcmgenet_mii_probe() function is split in two to accommodate
>> this. The new function bcmgenet_mii_connect() handles the first
>> half of the functionality before the MAC initialization, and the
>> bcmgenet_mii_config() function is extended to provide the remaining
>> PHY configuration following the MAC initialization.
>>
>> Fixes: 484bfa1507bf ("Revert "net: bcmgenet: Software reset EPHY after power on"")
>> Signed-off-by: Doug Berger <opendmb@...il.com>
> 
> Acked-by: Florian Fainelli <f.fainelli@...il.com>
> 
> We will have to see how difficult it might be to back port towards
> stable trees of interest, hopefully not too difficult.
> 

There is more going on here with the MAC reset than this commit resolves
and I am actively investigating a different approach that may include
the reversion of this commit.

Therefore, I would recommend not spending effort attempting to backport
this specific commit until I have submitted a more complete solution
(hopefully in the near future :).

Sorry for any confusion this creates.
    Doug