netdev - Re: [PATCH net] netdevsim: Fix use-after-free during device dismantle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191031.123604.1098090081443503807.davem@davemloft.net>
Date:   Thu, 31 Oct 2019 12:36:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, jakub.kicinski@...ronome.com,
        jiri@...lanox.com, sfr@...b.auug.org.au, mlxsw@...lanox.com,
        idosch@...lanox.com
Subject: Re: [PATCH net] netdevsim: Fix use-after-free during device
 dismantle

From: Ido Schimmel <idosch@...sch.org>
Date: Thu, 31 Oct 2019 18:20:30 +0200

> From: Ido Schimmel <idosch@...lanox.com>
> 
> Commit da58f90f11f5 ("netdevsim: Add devlink-trap support") added
> delayed work to netdevsim that periodically iterates over the registered
> netdevsim ports and reports various packet traps via devlink.
> 
> While the delayed work takes the 'port_list_lock' mutex to protect
> against concurrent addition / deletion of ports, during device creation
> / dismantle ports are added / deleted without this lock, which can
> result in a use-after-free [1].
> 
> Fix this by making sure that the ports list is always modified under the
> lock.
 ...
> Fixes: da58f90f11f5 ("netdevsim: Add devlink-trap support")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reported-by: syzbot+9ed8f68ab30761f3678e@...kaller.appspotmail.com

Applied.

> David, Stephen, this is going to conflict when you merge net into
> net-next. Should be resolved like this:
> https://github.com/idosch/linux/commit/a5ef0bd24450947570340a2b5caa9e01edc0612e

Thanks for the heads up.