netdev - Re: [PATCH net-next v2 0/8] Control action percpu counters allocation by netlink flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191030.180825.592258061800796198.davem@davemloft.net>
Date:   Wed, 30 Oct 2019 18:08:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vladbu@...lanox.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, mleitner@...hat.com, dcaratti@...hat.com,
        mrv@...atatu.com, roopa@...ulusnetworks.com
Subject: Re: [PATCH net-next v2 0/8] Control action percpu counters
 allocation by netlink flag

From: Vlad Buslov <vladbu@...lanox.com>
Date: Wed, 30 Oct 2019 16:08:59 +0200

> In order to allow configuring action counters allocation type at
> runtime, implement following changes:
> 
> - Implement helper functions to update the action counters and use them
>   in affected actions instead of updating counters directly. This steps
>   abstracts actions implementation from counter types that are being
>   used for particular action instance at runtime.
> 
> - Modify the new helpers to use percpu counters if they were allocated
>   during action initialization and use regular counters otherwise.
> 
> - Extend action UAPI TCA_ACT space with TCA_ACT_FLAGS field. Add
>   TCA_ACT_FLAGS_NO_PERCPU_STATS action flag and update
>   hardware-offloaded actions to not allocate percpu counters when the
>   flag is set.
 ...

I like both how this is implemented and how the patch series was split
up.

Series applied, thank you.