netdev - Re: [PATCH net-next v4 6/6] sfc: add XDP counters to ethtool stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c84e5ec-95c7-357c-fddf-1f74f86b62ab@gmail.com>
Date:   Thu, 31 Oct 2019 14:20:44 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jesper Dangaard Brouer <brouer@...hat.com>,
        Charles McLachlan <cmclachlan@...arflare.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-net-drivers@...arflare.com
Subject: Re: [PATCH net-next v4 6/6] sfc: add XDP counters to ethtool stats

On 10/31/19 2:13 PM, Jesper Dangaard Brouer wrote:
> On Thu, 31 Oct 2019 10:24:23 +0000
> Charles McLachlan <cmclachlan@...arflare.com> wrote:
> 
>> Count XDP packet drops, error drops, transmissions and redirects and
>> expose these counters via the ethtool stats command.
>>
>> Signed-off-by: Charles McLachlan <cmclachlan@...arflare.com>
> 
> I'm going to ACK this even-though I don't like these driver specific
> counters.  Given we have failed to standardize this, I really cannot
> complain.  Hopefully we will get this standardized later
> 
> Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>
> 
> Left code below, if Ahern want to complain ;-)

testing the patches now.

As for the driver specific counters, I have the same opinion. I'd rather
have counters than wait for some alignment.