netdev - Re: [PATCH net] net: dsa: bcm_sf2: Fix IMP setup for port different than 8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 01 Nov 2019 15:09:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: bcm_sf2: Fix IMP setup for port
 different than 8

From: Florian Fainelli <f.fainelli@...il.com>
Date: Thu, 31 Oct 2019 15:54:05 -0700

> Since it became possible for the DSA core to use a CPU port different
> than 8, our bcm_sf2_imp_setup() function was broken because it assumes
> that registers are applicable to port 8. In particular, the port's MAC
> is going to stay disabled, so make sure we clear the RX_DIS and TX_DIS
> bits if we are not configured for port 8.
> 
> Fixes: 9f91484f6fcc ("net: dsa: make "label" property optional for dsa2")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied and queued up for -stable.